This repository has been archived by the owner on Dec 18, 2020. It is now read-only.
[ENHANCEMENT] Refactored kernel structure #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| protected function getContext() | ||
| { | ||
| if (null === $this->context) { |
There was a problem hiding this comment.
We can make "context" a kernel parameter that willl automatically be available in the dependency injection container. I believe.
danrot
changed the title
danrot
changed the title
|
Updatred. Porbley some conflict with ContentBUndle |
This was referenced Aug 5, 2014
|
@danrot this should be good now, note you will need the referenced PRs above.. i.e. https://github.com/sulu-cmf/SuluMediaBundle/issues/54 |
danrot
changed the title
| { | ||
| $bundles = parent::registerBundles(); | ||
| $bundles[] = new Symfony\Bundle\SecurityBundle\SecurityBundle(); | ||
| $bundles[] = new Bazinga\Bundle\HateoasBundle\BazingaHateoasBundle(); |
There was a problem hiding this comment.
@dantleech Would you really put that into the AdminKernel? If some parts of the API are exposed on the website also, this bundle will probably also be needed.
There was a problem hiding this comment.
Will move to Abstract
added 2 commits
August 8, 2014 14:57
dantleech
added a commit
to sulu/sulu
that referenced
this pull request
Aug 14, 2014
dantleech
added a commit
to sulu/sulu
that referenced
this pull request
Oct 31, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored kernel structure.
Tasks:
Informations: