Feature/refactoring strucure names #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <?php | ||
| /* | ||
| * This file is part of the Sulu CMS. | ||
| * |
There was a problem hiding this comment.
This and the Snippet class are not used.
dantleech
force-pushed
the
feature/refactoring_strucure_names
branch
from
2b66c6c
to
df39bff
Compare
dantleech
added a commit
that referenced
this pull request
May 29, 2015
Feature/refactoring strucure names
|
|
||
| throw new \RuntimeException('Migrate this'); | ||
|
|
||
| // Structure as used below no longer exists. |
There was a problem hiding this comment.
Which structure does not exist as used below?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the
Component\Structrure\*classes toComponent\Metadata\*Metadata.This is to reduce the confusion about what these classes actually do and to allow better naming possiblities for other classes that talk about strutures and not structure metadata.
We should also rename the
ContentContainertoStructureContainer, and useStructurein general to refer to things derived from