Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute values are translatable in Sylius but no translation information or locale code are in the serialization payload now #46

Open
AndreasA opened this issue Mar 17, 2022 · 1 comment

Comments

@AndreasA
Copy link
Contributor

With this change 51496d6 the locale code for attribute values has been lost. if you want to go with the same behavior as for the attribute itself, you should actually add a translations array and provide all necessary translations there.

As it makes sense to have attributes translated, this should really be fixed, e.g. a color attribute could be red in English but rot in German or even something like lengths with units, e.g. 5,08 cm and 2 inch.

@wachterjohannes
Copy link
Member

@AndreasA as we discussed that in a call: there was a change of the payload regarding the attributes. We should document that in the UPGRADE.

Additionally there is a bug with this mentioned commit where we changed the behaviour for translated values. As we also discussed feel free to create a PR for to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants