Skip to content
This repository has been archived by the owner on Dec 18, 2020. It is now read-only.

Check bundle dependencies (remove dev-master's) #112

Closed
danrot opened this issue Jul 24, 2014 · 6 comments
Closed

Check bundle dependencies (remove dev-master's) #112

danrot opened this issue Jul 24, 2014 · 6 comments

Comments

@danrot
Copy link
Contributor

danrot commented Jul 24, 2014

Check if all the dev-master dependencies can be defined to a specific release

@danrot danrot added this to the Release 0.6.0 milestone Jul 24, 2014
@chirimoya
Copy link
Member

ping @danrot ... please add list of bundles

@danrot
Copy link
Contributor Author

danrot commented Jul 29, 2014

  • ratchet
  • serializer
  • http-cache
  • rest-bundle
  • liip-theme
  • doctrine-fixtures
  • doctrine-extensions

@chirimoya chirimoya removed this from the Release 0.6 milestone Aug 6, 2014
@dantleech
Copy link
Contributor

+1

@dantleech dantleech changed the title Check bundle dependencies Check bundle dependencies (remove dev-master's) Oct 2, 2014
@dantleech
Copy link
Contributor

Another task which is more easily accomplished when we have a full functional tests suite

@danrot
Copy link
Contributor Author

danrot commented Oct 22, 2014

@sulu-cmf/developer I am going to remove all the dev-dependencies now and let all the tests run. From now on we don't use the minimum-stability option anymore. And if there is a dev dependency we need, please use the following notation in the other bundles to stop the installation from failing:

"require": {
    "some-vendor/some-bundle": "@dev"
}

@danrot
Copy link
Contributor Author

danrot commented Oct 22, 2014

Probably we even could remove more dependencies than I did now from sulu-standard, e.g. the doctrine orm doesn't have to be a direct dependency. IMHO the ideal solution would be that only our bundles plus the necessary suggestions goes in sulu-standards composer.json.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants