Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled cache environment are hardcoded #4141

Closed
alexander-schranz opened this issue Sep 11, 2018 · 2 comments
Closed

Disabled cache environment are hardcoded #4141

alexander-schranz opened this issue Sep 11, 2018 · 2 comments
Labels
Feature New functionality not yet included in Sulu

Comments

@alexander-schranz
Copy link
Member

alexander-schranz commented Sep 11, 2018

Q A
Bug? no
New Feature? no
Sulu Version 2.0.0-alpha-3

Actual Behavior

Currently the environments where the cache is disabled are hardcoded see:

private function shouldCache(ContainerInterface $container): bool
{
return !in_array($container->getParameter('kernel.environment'), ['dev', 'test']);
}

Expected Behavior

We should use canBeDisabled configuration and use PrependConfigurationExtension instead with kernel.debug as default or better provide a default based on the env to don't crash the old behaviour.

@alexander-schranz alexander-schranz added this to the Release 2.0 milestone Sep 25, 2018
@danrot danrot added Feature New functionality not yet included in Sulu and removed Enhancement labels Jan 28, 2020
@danrot danrot removed this from the Release 2.0 milestone Feb 12, 2020
@niklasnatter
Copy link
Contributor

I think this should be fixed via #5303?

@alexander-schranz
Copy link
Member Author

@nnatter yes this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New functionality not yet included in Sulu
Projects
None yet
Development

No branches or pull requests

3 participants