Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viewdirs vs direction in cast_rays #92

Open
bring728 opened this issue Oct 24, 2023 · 0 comments
Open

viewdirs vs direction in cast_rays #92

bring728 opened this issue Oct 24, 2023 · 0 comments

Comments

@bring728
Copy link

Hi! Thank you for your wonderful work.

I have a question about

basis_matrix = torch.stack([ortho1, ortho2, directions], dim=-1)
this function. Why do you use the directions vector instead of the normalized vector viewdir? I guess basis_matrix should be a rotation matrix and each column should be a normalized vector. So shouldn't I use viewdir instead of directions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant