Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Ctrl-Page-Up/Ctrl-Page-Down go to previous/next tab as in many browsers #1049

Closed
nneil opened this issue Jul 27, 2018 · 10 comments
Closed

Comments

@nneil
Copy link

nneil commented Jul 27, 2018

My hands have learnt this combination and become confused in Sumatra.

@AndrejIT
Copy link

In my IDE and in browser i have tens of tabs, so i have "Ctrl+Tab cycles through tabs in recently used order" option on, and i am extremely used to it.
I personally don't work with pdf that much, but you can keep in mind, that some people may really make use of "recently used order" option.

@baldandbrave
Copy link

@kjk Is this keyboard shortcut in the development plan? Really getting used to it.
I would like to contribute but I didn't find the code assigning the shortcut. I can make PR if you could point me the code location.

@GitHubRulesOK
Copy link
Collaborator

GitHubRulesOK commented Apr 30, 2020

@baldandbrave
The shortcut key press for selecting and cycling tabs is documented in several manual pages
such as https://www.sumatrapdfreader.org/docs/Keyboard-shortcuts.html so they need to be honoured
Tabs
Ctrl + Tab - go to next tab
Ctrl + Shift + Tab - go to previous tab
Alt + 1 - go to tab 1. Use 2, 3 etc. up to 8 to go to n-th tab
Alt + 9 - go to last tab

Ctrl Page up and down are already allocated to FULL Page Up Down actions (i.e. next and previous pages)
Thus they would need to be repurposed from Adobe Acrobat natural control of a page at a time behaviour or similar next full page in a multi-page image viewer e.g. IrfanView to a less natural behaviour for viewer users (although it may be natural for browsers to go to next tabbed page as they are single page viewers)

If you think changing historic use would be acceptable to the majority of users (that expect behaviour identical to Adobe Reader, Irfanview etc.) you could look at swapping the tab control behaviours over to page control behaviours, but I think that is redefining it the wrong way round and would be adding to confusion. Browsers are not document viewers, but they should have used CTRL Tab for controlling tabs.

To answer your question on where is the code it is logically found from Tabs On Ctrl Tab

@baldandbrave
Copy link

@GitHubRulesOK
Thanks for your explanation and your dedicated contribution for this great tool!
It does makes sense to adapt to key bindings in Acrobat considering Sumatra is a doc viewer and doesn't work like web browsers.
I think we might as well look for a workaround with some process-wise key/gesture binder (or just get used to Ctrl+Tab)

@nneil
Copy link
Author

nneil commented May 1, 2020

I don’t think it makes sense to use the historical (old fashioned) Acrobat keystrokes. Most people use their web browser far more than they do a PDF reader. Even reading PDFs within the browser. In this case it’s natural to follow the control page up, control page down key convention.

@SumatraPeter
Copy link

In this case it’s natural to follow the control page up, control page down key convention.

Ctrl+Tab and Shift+Ctrl+Tab have worked in every tabbed browser I recall using, so I'd argue they constitute convention as much, if not more, than Ctrl+PgUp/PgDn.

@nneil
Copy link
Author

nneil commented May 2, 2020

But Ctrl-shift-tab is three keys, which should be reserved for unusual actions. With control page up and page down you can keep your finger on the control key and step back and forwards easily. It’s a much better pair of shortcut keys.

@GitHubRulesOK
Copy link
Collaborator

@nneil
For each user it will differ (and other keyboards are available) on my keyboard ctrl shift and tabs are together and usable by one my free left hand, whereas for my page up /down I need to let go of the mouse, then span my right hand fully to reach the page down key (top right of the numeric pad) for me that's slower and more painful

@SumatraPeter
Copy link

Your usage pattern matches mine exactly @GitHubRulesOK, and of course we have years of muscle memory associated with these common actions.

For the record I'm not at all opposed to kjk adding Ctrl+PgUp/PgDn as an addition to Ctrl+Tab/Shift+Ctrl+Tab if he so wishes, but doing so in lieu of the latter would make the app unusable for me.

@GitHubRulesOK
Copy link
Collaborator

@kjk
with custom shortcuts this issue should now be addressed ?

@kjk kjk changed the title Feature: Make Ctrl-Page-Up/Ctrl-Page-Down go to previous/next tab as in many browsers Make Ctrl-Page-Up/Ctrl-Page-Down go to previous/next tab as in many browsers Jun 8, 2022
@kjk kjk closed this as completed in cced53f Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants