The new tag and ctx_id parameters of get_func_stats() are ignored

[sm-Fifteen]

The latest release of yappi has begun to phase out get_func_stats(filter={}) in favor of tag, ctx_id and filter_callback. However, I ended up noticing while using tag to profile coroutines, it seems that tag and ctx_id are currently being ignored.

yappi/yappi/yappi.py

Lines 1094 to 1104 in b0e424f

	tag = filter.get('tag', tag)
	ctx_id = filter.get('ctx_id', tag)
	# multiple invocation pause/resume is allowed. This is needed because
	# not only get() is executed here.
	_yappi._pause()
	try:
	stats = YFuncStats().get(filter=filter, filter_callback=filter_callback)
	finally:
	_yappi._resume()
	return stats

(Notice how both variables aren't passed or stored anywhere)

It can currently be worked around by writing this:

yappi.get_func_stats(
	filter=dict(tag=ctx_tag),
	#...
)

rather than this

yappi.get_func_stats(tag=ctx_tag)

[sumerc]

Yes. I also happen to see this a few days ago.

So much focusing on backward compatibility makes me lose sight :)

It will be fixed in #55 with more tests on this usage pattern along with some other minor issues as well and I will be releasing a new hotfix version in few days hopefully.

[sumerc]

Fixed in #55

[sumerc]

Released a new hotfix version with this fix.

[sm-Fifteen]

Excellent, thank you @sumerc!