Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not yet Leaflet 1.0.0 compatible #8

Open
eldang opened this issue Jul 17, 2015 · 5 comments
Open

Not yet Leaflet 1.0.0 compatible #8

eldang opened this issue Jul 17, 2015 · 5 comments
Assignees

Comments

@eldang
Copy link

eldang commented Jul 17, 2015

I'm trying to make a local copy work with Leaflet 1.0.0. If I can figure it out, I'll submit a pull request.

@eldang
Copy link
Author

eldang commented Jul 17, 2015

The biggest issue so far: 1.0.0 has removed TileLayer.Canvas in favour of GridLayer. Details at https://github.com/Leaflet/Leaflet/blob/master/CHANGELOG.md

@eldang
Copy link
Author

eldang commented Jul 17, 2015

That's not all there is to it. By replacing TileLayer.Canvas references with GridLayer ones I can get this to run without error messages, but it's not actually drawing anything, or as far as I can tell even loading the vector tile data. I'm afraid I'm out of my depth here.

@summer4096
Copy link
Owner

Leaflet 1.0.0??? When did that happen??? It seems like only yesterday, mourner was saying that 1.0.0 was just around the corner for several consecutive years, but now here it is!

I'll take a look at this as soon as I can. I think the issue is most likely related to the fact that TileLayer.Canvas would create <canvas> elements, while GridLayer will not.

@summer4096 summer4096 self-assigned this Jul 17, 2015
@eldang
Copy link
Author

eldang commented Jul 17, 2015

Haha, I sympathise, having got exactly the same sense about 1.0.0 until the past couple of weeks. If I can help without real web graphics knowledge--perhaps by testing a PR or writing a how-to once I have it working--I'll be happy to.

@summer4096
Copy link
Owner

Thanks, I'll definitely ask you to test it when I think it's working. Hopefully it can be compatible with leaflet 1.0.0 and the previous version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants