Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link embed in summernote editor on copy paste or by typing #2049

Closed
zerotoinfinite2006 opened this issue Sep 6, 2016 · 1 comment
Closed

Comments

@zerotoinfinite2006
Copy link

[This isn't a issue but a feature request]

Is it possible to add embed feature in editor either when link is copy pasted or when it is typed (example: Quora editor). When URL is pasted or written, link will be converted to Embed. I've found embed.js and other can do that but they either need a event to fire or partial page refresh.

Reason why it should be implemented:

I real world people usually tends to copy paste URL instead of clicking toolbar button to embed it for them. Embedding is a real social requirement for conversation.
I have absolute no knowledge about client side scripting but my guess is implement is like Embed.Js where user can choose which embed feature they want to include (ex: Youtube, Vimeo, Instagram, Twitter etc.)

Alternatively, if there is a snippet which can transmit URL to blackened code then I can write the same in C#. I.e.

When user past/write a link, javacript code will send that URL to server side where embed code will be returned to client in the form of JSON. Client, then, will replace the URL with the embed code returned from server.

I can write server side code to generate embed code (C#)

Note: This is my first response on github. Please let me know if this isn't fit here or if I have to edit my question/request.

@DennisSuitters
Copy link
Member

This feature has already been implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants