Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(editorconfig): use lf for end_of_line #1010

Merged
merged 1 commit into from Apr 3, 2022

Conversation

kevinhwang91
Copy link
Contributor

Current project files all use lf instead of crlf.

@sumneko
Copy link
Collaborator

sumneko commented Apr 2, 2022

Should just remove this setting.
By default, it will be selected according to your local platform.

@kevinhwang91
Copy link
Contributor Author

I don't think so. If the project is used editorconfig, all users editing the file should respect the rule but don't depend on their OS. For now, I enter a file, my Neovim plugin for editorconfig will format the end of the line to become crlf automatically, and my gutter is hinting me all lines are changed.

@sumneko
Copy link
Collaborator

sumneko commented Apr 3, 2022

It is best to use the default behavior of "respecting existing newline characters"

@sumneko sumneko merged commit 0c84fa7 into LuaLS:master Apr 3, 2022
@kevinhwang91 kevinhwang91 deleted the update-editorconfig branch April 3, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants