Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional flag (?) to overloads in love2d and lovr builders #1180

Merged
merged 2 commits into from May 29, 2022

Conversation

C3pa
Copy link
Contributor

@C3pa C3pa commented May 28, 2022

Summary of changes:

  • Made builders add ? next to argument names if the argument has a default value.
  • isTableOptional refactored to getOptional that returns '?' or an empty string if based on whether the argument is or is not optional. Ready to be inserted in a string with string.format.

The second change is a separate commit and can be reverted if not desired.

@sumneko sumneko merged commit 9a833e6 into LuaLS:master May 29, 2022
@sumneko
Copy link
Collaborator

sumneko commented May 29, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants