Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defold engine meta #1665

Merged
merged 5 commits into from Nov 11, 2022
Merged

Defold engine meta #1665

merged 5 commits into from Nov 11, 2022

Conversation

SalavatR
Copy link
Contributor

@SalavatR SalavatR commented Nov 3, 2022

Hello! i generated some meta for Defold engine

with fork of https://github.com/d954mas/defold-api-emmylua/

@@ -0,0 +1,9 @@
name = 'Defold'
files = {'game.project'}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name is too common

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!
Here is the empty project, in defold engine,
also we can associate with file extensions .gui_script, .script, .collection, .render_script, .input_binding,
but in fact on start we have always only one .project in root and one or more .collection in subfolders
MyProject123.zip

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can
use one of this words in .project file?

[bootstrap]
main_collection =

[project]
title =

meta/3rd/Defold/library/bitop.lua Outdated Show resolved Hide resolved
meta/3rd/Defold/library/io.lua Outdated Show resolved Hide resolved
meta/3rd/Defold/library/os.lua Outdated Show resolved Hide resolved
@SalavatR
Copy link
Contributor Author

SalavatR commented Nov 11, 2022

@sumneko is it normal to ad files.associations in config.lua?

@sumneko
Copy link
Collaborator

sumneko commented Nov 11, 2022

@sumneko is it normal to ad files.associations in config.lua?

LSP has no relevant regulations on file association. You can do this, but it will only affect VSCode.

@SalavatR
Copy link
Contributor Author

@sumneko i added some changes in config file, is it enough, but i'm not sure is it correct,
files = {'game.project', '%.script', '%.gui_script'} we need to have at least one of .script or .gui_script file

@sumneko
Copy link
Collaborator

sumneko commented Nov 11, 2022

I think it is enough.
But I rechecked files Associations, which contains many files unrelated to Lua.
I think it might be more appropriate for you to make a extension specifically, you can refer to https://github.com/sumneko/lua-language-server/wiki/Libraries#bundling-in-a-plugin-extension.

@sumneko
Copy link
Collaborator

sumneko commented Nov 11, 2022

To add, I guess your goal is to create a development environment, rather than simply providing definition files.

If this is the case, I suggest you make a separate extension and provide the definition file in your extension using the method in wiki.

@SalavatR
Copy link
Contributor Author

I left only lua file associations

@SalavatR
Copy link
Contributor Author

for all other files i'll make extension

@sumneko
Copy link
Collaborator

sumneko commented Nov 11, 2022

for all other files i'll make extension

If I am the user of Defold, I hope I can use your extension directly after installing it, instead of being discovered by my extension and asking whether to apply a the Defold environment.

@SalavatR
Copy link
Contributor Author

I think this meta only for lua develop, other files extensions are editing from defold editor, and maybe redundant here

@sumneko sumneko merged commit 87f7418 into LuaLS:master Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants