Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 17.1 crash when using UIDatePicker #133

Closed
sleivysarnas opened this issue Oct 30, 2023 · 28 comments
Closed

iOS 17.1 crash when using UIDatePicker #133

sleivysarnas opened this issue Oct 30, 2023 · 28 comments

Comments

@sleivysarnas
Copy link

sleivysarnas commented Oct 30, 2023

We are using 4.3.4 version of SumUp SDK. After we updated to iOS 17.1 our application started crashing when you are trying to select time in UIDatePicker. Removing SumUp SDK fixes the issue. Apparently, it uses method swizzling which does something that crashes the app. Please fix it ASAP because until then our customers will not be able to use SumUp terminals - we are forced to remove it from our application because it crashes in places which are not even related to SumUp. I am attaching stack trace:

*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[__NSPlaceholderDictionary initWithObjects:forKeys:count:]: attempt to insert nil object from objects[0]'

image
@mikegunning
Copy link

This is happening to us too. Only when selecting a time, picking a date seems fine. Only on iPadOS 17.1.

Can this be addressed soon please.

@Akhila-ramesh
Copy link

This is happening on our app on all devices. Can you please fix this issue as soon as possible.

@annaafanasyeva-sumup
Copy link

Hi @sleivysarnas, so far we have been unable to reproduce the issue.

Could you please verify if it is reproducible in the SumUpSDKSampleApp that comes together with the SumUpSDK and share the modified SumUpSDKSampleApp with us?

@mikegunning
Copy link

I have created a skeleton project that pulls in your cocoapod that causes the date picker to crash. It will only crash on a physical device running iOS17.1.

If I remove the pod, it does not crash. I have tested with all the pods our app uses, and unfortunately it's this pod that crashes it. A lot of customers are also raising this to our support.

@sleivysarnas
Copy link
Author

Strangely, it does not crash on iOS 17.1 with physical device using SumUp sample app. Something must be different in project setup or something is conflicting with other libraries. Will update as soon as I figure this out. Any insights would be appreciated too.

@annaafanasyeva-sumup
Copy link

Hi, we were able to reproduce the issue and currently working on a fix. We will come back to you with an update next week.

@Petervanburg
Copy link

We have the same issue on all the devices on ios17.1
We have also created an small test project with only the sumupsdk package and 1 UIDatepicker control.
Once clicking on the time part the app crashes.
Any idea howto solve this asap? We have more than 600 devices in the field.. Regards

@alexeytarasoff
Copy link

The same issue on all the devices on ios17.1 and ios17.2
How to solve the problem?

@keySEE
Copy link

keySEE commented Nov 8, 2023

Hi @annaafanasyeva-sumup,

Can you please advise when you are expecting a new release with the fix will be available?

@annaafanasyeva-sumup
Copy link

Hi, thank you for your patience! We are currently preparing the new release and will make it available later this week.

@SimoVanigliapro
Copy link

The same issue on all the devices on ios17.1 and ios17.2 How to solve the problem?

the same issue me, if i remove the sumup library works

@vx8
Copy link

vx8 commented Nov 10, 2023

Same happening here.. can we have a URGENT fix?

@SimoVanigliapro
Copy link

any news about the new release?

@annaafanasyeva-sumup
Copy link

Hi, please try version 4.4.0 which includes the fix for this issue! It is available under: https://github.com/sumup/sumup-ios-sdk/releases/tag/v4.4.0

@SimoVanigliapro
Copy link

works thanks ;)

@mikegunning
Copy link

I was hoping the minimum deployment would have stayed the same as this was a critical bug. We have a lot of customers on iOS 12 still.

@SimoVanigliapro
Copy link

i need version with last minimun deployment because many customer use it

@vx8
Copy link

vx8 commented Nov 13, 2023

wtf... why would you increase the min deployment target by 2 versions for a hotfix??

We have thousands of customers on iOS13..

@vx8
Copy link

vx8 commented Nov 14, 2023

Is there an estimated date for the fix with ios13 support?

@jadeburton-sumup
Copy link
Collaborator

We’re sorry for the inconvenience. We are working on SDK 4.3.5, a hotfix release that will fix this issue without changing the minimum deployment target.

It will take some more time for us to release this version based on an older version, as our internal codebase and tooling no longer support iOS 12 and 13.

We will provide a progress update on this later in the week.

@jadeburton-sumup
Copy link
Collaborator

Update on the 4.3.5 hotfix: we are finalizing testing and will release this early next week if all goes well. For those with a minimum deployment target of 14 or higher, please consider upgrading to 4.4.0 to fix this issue.

@mikegunning
Copy link

Is there any updates to when to expect 4.3.5?

@annaafanasyeva-sumup
Copy link

annaafanasyeva-sumup commented Nov 21, 2023

Hi, SDK 4.3.5 with iOS 12 & 13 minimum deployment target support is available under: https://github.com/sumup/sumup-ios-sdk/releases/tag/v4.3.5.

@matteobianchi3
Copy link

Hi, SDK 4.3.5 with iOS 12 & 13 minimum deployment target support is available under: https://github.com/sumup/sumup-ios-sdk/releases/tag/v4.3.5.

@annaafanasyeva-sumup how did you manage to solve the issue? (same happens to us with a legacy project still compiled with Xcode 14 😢)

@SimoVanigliapro
Copy link

thanks, now works

@jadeburton-sumup
Copy link
Collaborator

@matteobianchi3 the problem was 2 category methods (tintColor, colorForStyle:) defined on UIColor; the 4.3.5 hotfix renames these to avoid collisions with same-named method(s) in iOS 17, while the 4.4.0 release completely removes them.

@SimoVanigliapro
Copy link

is it normal that after use sumapp payment and loggin inside the page, after some minute re-ask the login?

@mikegunning
Copy link

this has finally fixed this issue also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests