Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rqid dialog can give false warning of multiple Rqids #330

Closed
Moonpile opened this issue Aug 19, 2022 · 0 comments · Fixed by #331
Closed

Rqid dialog can give false warning of multiple Rqids #330

Moonpile opened this issue Aug 19, 2022 · 0 comments · Fixed by #331
Assignees
Labels
type: bug Something isn't working. Use "fix: " commit message
Milestone

Comments

@Moonpile
Copy link
Contributor

What: Describe the bug

If I have "i.skill.1-h-spear-javelin" and "i.skill.1-h-spear-javelin-offhand" in the world, and open the Rqid dialog on the non-offhand one, I get a warning that there are "Multiple rqids with same priority". If I open the Rqid dialog on the offhand one, I do not have that warning.

How: To Reproduce

Steps to reproduce the behavior:

  1. Create two items in the world and give them rqids where the first rqid is a substring of the second.
  2. Open the Rqid dialog on the first (shorter one) and see the warning.
  3. Open the Rqid dialog on the second (longer one) and there is no warning.

Expected behavior

There should be no warning on either Rqid dialog (unless there really is an Rqid that is exactly the same).

Screenshots

image.

image

Environment - please paste the information from foundry settings tab "support" button:

RQG System, Foundry 9

Additional context

n/a

@Moonpile Moonpile added the type: bug Something isn't working. Use "fix: " commit message label Aug 19, 2022
@wake42 wake42 self-assigned this Aug 19, 2022
@wake42 wake42 added this to the 1.16.0 milestone Aug 19, 2022
@wake42 wake42 linked a pull request Aug 19, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working. Use "fix: " commit message
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants