Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedding a weapon shows a warning for every usage without linked skill #591

Closed
wake42 opened this issue Jul 17, 2023 · 0 comments · Fixed by #587
Closed

Embedding a weapon shows a warning for every usage without linked skill #591

wake42 opened this issue Jul 17, 2023 · 0 comments · Fixed by #587
Assignees
@wake42
Labels
type: bug Something isn't working. Use "fix: " commit message
Milestone
2.2.6 [done]

Comments

@wake42
Copy link
Collaborator

wake42 commented Jul 17, 2023

What: Describe the bug

When embedding a weapon an error notification is erroneously shown for every usage that does not have a linked skill.
All skills that are linked are embedded correctly.

How: To Reproduce

Steps to reproduce the behavior:

  1. Drag for example a broadsword to an actor
  2. Multiple error notifications are shown
@wake42 wake42 added the type: bug Something isn't working. Use "fix: " commit message label Jul 17, 2023
@wake42 wake42 added this to the 2.3.0 milestone Jul 17, 2023
@wake42 wake42 self-assigned this Jul 17, 2023
@wake42 wake42 closed this as completed in 160b8f9 Jul 17, 2023
@github-actions github-actions bot mentioned this issue Jul 17, 2023
Merged
@wake42 wake42 modified the milestones: 2.3.0, 2.2.6 Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wake42 wake42

Labels
type: bug Something isn't working. Use "fix: " commit message
Projects
None yet
Milestone
2.2.6 [done]
Development

Successfully merging a pull request may close this issue.

chore(master): release 2.2.6 sun-dragon-cult/fvtt-system-rqg
1 participant
@wake42