Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to english when searching for a rqid in another language #643

Closed
wake42 opened this issue Oct 22, 2023 · 0 comments · Fixed by #645
Closed

Fallback to english when searching for a rqid in another language #643

wake42 opened this issue Oct 22, 2023 · 0 comments · Fixed by #645
Assignees
@wake42
Labels
type: bug Something isn't working. Use "fix: " commit message
Milestone
3.2.1 [done]

Comments

@wake42
Copy link
Collaborator

wake42 commented Oct 22, 2023

Why: Is your feature request related to a problem?

In a world set to a language other than english, clicking on a rqidLink to a description for example would not work if the exact language version does not exist.

What: Describe the solution you'd like

It would be better if the english version was opened if the exact match was not there.
@wake42 wake42 added the type: feature New feature not currently present. Use "feat: " commit message label Oct 22, 2023
@wake42 wake42 added this to the 3.3.0 milestone Oct 22, 2023
@wake42 wake42 self-assigned this Oct 22, 2023
@wake42 wake42 modified the milestones: 3.3.0, 3.2.1 Oct 23, 2023
@wake42 wake42 added type: bug Something isn't working. Use "fix: " commit message and removed type: feature New feature not currently present. Use "feat: " commit message labels Oct 23, 2023
@wake42 wake42 closed this as completed in af663e3 Oct 23, 2023
@github-actions github-actions bot mentioned this issue Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wake42 wake42

Labels
type: bug Something isn't working. Use "fix: " commit message
Projects
None yet
Milestone
3.2.1 [done]
Development

Successfully merging a pull request may close this issue.

chore(master): release 3.2.1 sun-dragon-cult/fvtt-system-rqg
1 participant
@wake42