Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen duplicate embedded item check #672

Closed
wake42 opened this issue Dec 3, 2023 · 3 comments · Fixed by #662
Closed

Loosen duplicate embedded item check #672

wake42 opened this issue Dec 3, 2023 · 3 comments · Fixed by #662
Assignees
Labels
type: enhancement Improvement to existing feature. Use "feat: " commit message
Milestone

Comments

@wake42
Copy link
Collaborator

wake42 commented Dec 3, 2023

Adding two javelins currently require you to rename them so they have unique names. Also splitting your currency into multiple piles requires that you rename your Lunars items to have unique names. Unique Physical Items do not have quantity (locked to 1) but it should still be possible to have more of them as separate items.

There is a check that all items (except RuneMagic) has to be unique <type+name> (see rqgItem.isDuplicateItem). RuneMagic was removed from the check since you must be able to have the same spell learned from multiple cults. The physical items (gear, armor & weapon) should also be excluded from this uniqueness check.

@wake42 wake42 added this to the 3.4.0 milestone Dec 3, 2023
@wake42 wake42 self-assigned this Dec 3, 2023
@wake42 wake42 added the type: enhancement Improvement to existing feature. Use "feat: " commit message label Dec 3, 2023
@wake42 wake42 changed the title Loosen duplicate name check Loosen duplicate embedded item check Dec 3, 2023
@wake42 wake42 closed this as completed in a399a0f Dec 3, 2023
@Moonpile
Copy link
Contributor

Moonpile commented Dec 3, 2023

Unique Physical Items do not have quantity (locked to 1)

I've always found this strange. I don't mind being able to have, say, 7 broadswords or 4 helmets.

@wake42
Copy link
Collaborator Author

wake42 commented Dec 4, 2023

The problem with having 7 broadswords is for example that you can't equip and fight with 7 broadswords, and if you would do that and the broadsword looses HP then all 7 will loose it because they are the same item (with a quantity number).

From what I can see the only downside is that you can't have a merchant with 7 broadswords for sale, but to handle all the complexity that comes with allowing quantity on these kinds of items doesn't seem reasonable to me. See #211 for more discussion about the obstacles with allowing it.

@Moonpile
Copy link
Contributor

Moonpile commented Dec 4, 2023

I know we've discussed this many times. I'd be ok with the side-effect of all 7 broadswords lose hit points. Maybe just have a warning pop up if you equip something and there's a quantity other than 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement to existing feature. Use "feat: " commit message
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants