Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old migrations & macros #685

Closed
wake42 opened this issue Jan 4, 2024 · 0 comments · Fixed by #678
Closed

Remove old migrations & macros #685

wake42 opened this issue Jan 4, 2024 · 0 comments · Fixed by #678
Assignees
Labels
type: enhancement Improvement to existing feature. Use "feat: " commit message
Milestone

Comments

@wake42
Copy link
Collaborator

wake42 commented Jan 4, 2024

Remove old migrations in preparation for an upcoming rewrite of the migration code.
Also check if provided macros should be removed / updated.

Removed most migrations, except the new ones and some for reference. The remaining will be removed or rewritten in #654
Note especially that the removal of migrateWeaponItemDamageBonus will make sure any weapon damage bonus definitions are not overwritten when updating the system.

Only the assign rqid to journals macro is left
assign-rqid-to-hit-locations does not work after hit location setting was removed, and migrate-old-journal-links should not be necessary anymore.

@wake42 wake42 added the type: enhancement Improvement to existing feature. Use "feat: " commit message label Jan 4, 2024
@wake42 wake42 added this to the 3.4.1 milestone Jan 4, 2024
@wake42 wake42 self-assigned this Jan 4, 2024
@wake42 wake42 closed this as completed in 633ab5a Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement to existing feature. Use "feat: " commit message
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant