Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not remove listeners properly #7

Open
ShimShamSam opened this issue Feb 26, 2018 · 0 comments
Open

Does not remove listeners properly #7

ShimShamSam opened this issue Feb 26, 2018 · 0 comments

Comments

@ShimShamSam
Copy link

ShimShamSam commented Feb 26, 2018

In the current code:

server.service(keys[i]).removeListener(ekeys[k], service[ekeys[k]].bind(this))

The bind(this) will create a new function. removeListener expects a reference to an already bound function. You'll have to store references to the functions added in the created hook in order to remove them properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant