Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to be more gender inclusive #17

Closed
wants to merge 1 commit into from
Closed

Update README.md to be more gender inclusive #17

wants to merge 1 commit into from

Conversation

p10q
Copy link
Contributor

@p10q p10q commented Nov 24, 2019

Nice project and generally nice attitude in the README! And I realize the main author is a woman, and it's easy to make mistakes with these things (I have). But it's good to avoid little micro expressions that encourage only 'fellas'.

Nice project and generally nice attitude in the README! And I realize the main author is a woman, and it's easy to make mistakes with these things (I have). But it's good to avoid little micro expressions that encourage only 'fellas'.
@coveralls
Copy link

coveralls commented Nov 24, 2019

Pull Request Test Coverage Report for Build 24

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 23: 0.0%
Covered Lines: 1599
Relevant Lines: 1599

💛 - Coveralls

@sunainapai
Copy link
Owner

@p10q Thank you for creating this pull request. I need a little change in the commit message before I merge this. The current commit message body is a long line (longer than 72 characters) which deviates from the commit message conventions I have been following. This can be seen in the output of git log.

Would you please update the commit message body and restrict the line lengths to a maximum of 72 characters?

Here are the steps you would need to follow:

git checkout patch-1
git commit --amend

# When the editor comes up, edit the commit message body and ensure that
# all lines are wrapped to a maximum of 72 characters. Save and quit the
# editor.

git push -f origin patch-1

@sunainapai
Copy link
Owner

Amended the commit message and merged to master as commit cebbf52.

@sunainapai sunainapai closed this Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants