Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing HTML anchors for Python 3 docset #58

Closed
IngoMeyer441 opened this issue Jan 30, 2023 · 7 comments
Closed

Missing HTML anchors for Python 3 docset #58

IngoMeyer441 opened this issue Jan 30, 2023 · 7 comments
Labels

Comments

@IngoMeyer441
Copy link

Thanks for this nice project, doing as much as posible in the terminal is always awesome! 馃槂

I tried dasht with the Python 3 docset. If I search for sys.argv for example, dasht finds sys.argv but the link behind it navigates to the top of the sys documentation page. Zeal jumps to the sys.argv section instead. I think there is a missing #sys.argv at the end of the found documentation URL. It this behavior docset dependent?

@sunaku
Copy link
Owner

sunaku commented Jan 31, 2023

Yes, this is a known issue (see #16) and pull requests are welcome. 馃檹 Long ago, I installed all available docsets and manually examined each of them to learn their individual style of URI fragments ("HTML anchors"). Some had them and others didn't.

@IngoMeyer441
Copy link
Author

IngoMeyer441 commented Jan 31, 2023

Ah I see 馃槥. Hmm, but how does Zeal handle this? Maybe dasht can be improved this way.

@IngoMeyer441
Copy link
Author

@sunaku
Copy link
Owner

sunaku commented Feb 4, 2023

Hi Ingo, I didn't look into the Zeal codebase link you provided yet. Instead, I tried installing the "python_3" docset on my end and attempted your search for sys.argv but I couldn't reproduce the problem! 馃挕 On my system, both the terminal based dasht search as well as the web based dasht-server search properly took me to the exact anchor in the HTML document.

Is your Python 3 docset installation up to date? Mine has the following timestamp and checksum. Please check.

$ cd ~/.local/share/dasht/docsets/
$ sha256sum Python_3.tgz
4c69f15063840872d855a3a1c7314f927c57c8fe1f48cfbe02fe24ab84bf0ad3 Python_3.tgz
$ date -Is -r Python_3.tgz
2022-12-08T03:29:22-08:00

@IngoMeyer441
Copy link
Author

Hi @sunaku,
sorry for my late reply. I set DASHT_DOCSETS_DIR to my Zeal docset directory to avoid duplicates. There are no tgz-files inside I could use for a checksum. But I tried to unset DASHT_DOCSETS_DIR again and installed the Python 3 docset with

dasht-docsets-install Python_3

When using the dasht docset, jumping to the correct doc location works. 馃槃 Sorry, I was not aware that the docsets of Dasht and Zeal differ. Is there no compatibility between the two?

@IngoMeyer441
Copy link
Author

IngoMeyer441 commented Feb 10, 2023

I ran diff on both Python 3 docset directories and the contained Contents directories do not differ. 馃槙

A diff on both database (docSet.dsidx) shows that they differ.

@IngoMeyer441
Copy link
Author

Since my problem was caused by using "foreign" docsets, I think this can be closed now. Thanks for your help and time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants