Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ioctl generation with linux HEAD fails #56

Open
sunfishcode opened this issue Apr 27, 2023 · 3 comments
Open

Ioctl generation with linux HEAD fails #56

sunfishcode opened this issue Apr 27, 2023 · 3 comments

Comments

@sunfishcode
Copy link
Owner

@joshtriplett As a followup to #53, I was investigating running the generator script with linux HEAD, but I'm hitting this error:

list.c: In function ‘list’:
include/linux/ext4.h:47:54: error: invalid application of ‘sizeof’ to incomplete type ‘struct compat_ext4_new_group_input’
   47 | #define EXT4_IOC32_GROUP_ADD            _IOW('f', 8, struct `)
      |                                                      ^~~~~~

It seems compat_ext4_new_group_input isn't defined in the uapi headers, but EXT4_IOC32_GROUP_ADD isn't usable without it. Should compat_ext4_new_group_input be moved into uapi?

@joshtriplett
Copy link
Contributor

groan, you're right. There were issues with defining compat_ext4_new_group_input, so I ended up dropping it, and the kernel compiles without having a definition of it.

Does the generator script work if you don't request that ioctl? Or does this require fixing the header?

@sunfishcode
Copy link
Owner Author

Commenting out that one ioctl allows the script to succeed. I've now done that and published a 0.3.6-head.0 prerelease based on the current linux master branch.

@joshtriplett
Copy link
Contributor

@sunfishcode Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants