Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c-scape: add pthread_setname_np (#139) #140

Merged
merged 7 commits into from
Sep 28, 2022

Conversation

HookedBehemoth
Copy link
Contributor

As mentioned in the issue #139, any code using threads fails to link. Since this commit, rust links against a pthread_setname_np on linux. Android is unaffected. rust-lang/rust@013986b

@sunfishcode
Copy link
Owner

The test failure is just that tests/examples.rs contains a nightly version string that needs to match the CI version.

@sunfishcode
Copy link
Owner

Otherwise, this PR looks good to me!

@HookedBehemoth
Copy link
Contributor Author

Ah my bad.
I have some unrelated IP test fail there now

---- ip_properties stdout ----
thread 'ip_properties' panicked at 'assertion failed: !ip!(\"ff01::\").is_global()', tests/net-ip.rs:396:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- ipv6_properties stdout ----
thread 'ipv6_properties' panicked at 'assertion failed: !ip!(\"ff01::\").is_global()', tests/net-ip.rs:758:5```

@sunfishcode
Copy link
Owner

That's due to a change on Rust nightly. I happen to have a patch to update the test here: 6011601. In theory, cherry-picking that in should fix it.

This syncs up mustang with the change "Fix `Ipv6Addr::is_global` to check
for global reachability rather than global scope".
@HookedBehemoth
Copy link
Contributor Author

yep that passes all tests on my end 👍🏻

@sunfishcode sunfishcode merged commit 7743804 into sunfishcode:main Sep 28, 2022
@sunfishcode
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants