Fill in signatures for pthread_cond*

[jplatte]

This wasn't easy to figure out, but I think now I'm at a point where it wouldn't take me that long to fill in most of the remaining signatures of functions with a commented-out libc!.

The padding bytes are most likely only correct for x86_64. What would I have to do to figure out the right padding for x86?

[sunfishcode]

This wasn't easy to figure out, but I think now I'm at a point where it wouldn't take me that long to fill in most of the remaining signatures of functions with a commented-out libc!.

Very cool!

The padding bytes are most likely only correct for x86_64. What would I have to do to figure out the right padding for x86?

The libc crate has libc-compatible declarations of all the types, including the pthread_* types. Currently mustang is emulating a --linux-gnu target. I think that means pthread_cond_t etc. are defined here.

[jplatte]

Is there a particular reason the padding in c-scape uses usize's rather than an array of u8?

[sunfishcode]

No particular reason; it could use either. usize ensures usize alignment, where byte arrays don't, but that's usually covered by other struct fields.

[jplatte]

I now copied sizes & alignment over from libc, adapted a bit based on the assumption that target_env = "musl" will always be false.

For SIZEOF_PTHREAD_CONDATTR_T I only copied the bits relevant for supported architectures.

[jplatte]

Ah, missed riscv64 in the condattr_t cfg list. Fixed now.

[jplatte]

Fixed libc-specific error. I thought I tested with that before, but maybe sth. changed when rebasing.

[sunfishcode]

Looks good!

For assumptions about target_env = "musl", I think if we do decide we want to add musl ABI support, we'd move these types into c-scape/src/data/linux/linux_gnu.rs, and then musl support could go in linux_musl.rs or so. Possibly with a factored-out linux.rs common to both. But in any case, I think what's here works for now.