Skip to content

Commit

Permalink
split analytics into global config and tracker-specific fields, fix u…
Browse files Browse the repository at this point in the history
…p install tracking
  • Loading branch information
konklone committed Apr 24, 2014
1 parent 5f27424 commit c5b9b05
Show file tree
Hide file tree
Showing 5 changed files with 25 additions and 15 deletions.
2 changes: 1 addition & 1 deletion .gitignore
Expand Up @@ -2,7 +2,7 @@
/bin
/gen
/res/values/keys.xml
/res/*/analytics*
/res/*/tracker_*
/.idea

# gradle/android studio stuff
Expand Down
21 changes: 14 additions & 7 deletions AndroidManifest.xml
Expand Up @@ -155,13 +155,20 @@
</receiver>

<service android:name=".notifications.NotificationService" />

<!-- Used for install referrer tracking -->
<receiver android:name="com.google.android.apps.analytics.AnalyticsReceiver" android:exported="true">
<intent-filter>
<action android:name="com.android.vending.INSTALL_REFERRER" />
</intent-filter>
</receiver>

<!-- Used for install referrer tracking-->
<service android:name="com.google.android.gms.analytics.CampaignTrackingService"/>
<receiver
android:name="com.google.android.gms.analytics.CampaignTrackingReceiver"
android:exported="true">
<intent-filter>
<action android:name="com.android.vending.INSTALL_REFERRER" />
</intent-filter>
</receiver>

<meta-data android:name="com.google.android.gms.analytics.globalConfigResource"
android:resource="@xml/analytics"
/>

</application>
</manifest>
6 changes: 6 additions & 0 deletions res/xml/analytics.xml
@@ -0,0 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<resources xmlns:android="http://schemas.android.com/apk/res/android">
<bool name="ga_anonymizeIp">true</bool>
<string name="ga_logLevel">warn</string>
<integer name="ga_dispatchPeriod">1</integer>
</resources>
8 changes: 4 additions & 4 deletions src/com/sunlightlabs/android/congress/CongressApp.java
Expand Up @@ -22,13 +22,13 @@ public synchronized Tracker appTracker() {
if (local == null) {

try {
getResources().getXml(R.xml.analytics);
getResources().getXml(R.xml.tracker_app);
} catch(Resources.NotFoundException e) {
hasLocal = false;
return null;
}

local = GoogleAnalytics.getInstance(this).newTracker(R.xml.analytics);
local = GoogleAnalytics.getInstance(this).newTracker(R.xml.tracker_app);
}

return local;
Expand All @@ -39,13 +39,13 @@ public synchronized Tracker globalTracker() {

if (global == null) {
try {
getResources().getXml(R.xml.analytics_global);
getResources().getXml(R.xml.tracker_global);
} catch(Resources.NotFoundException e) {
hasGlobal = false;
return null;
}

global = GoogleAnalytics.getInstance(this).newTracker(R.xml.analytics_global);
global = GoogleAnalytics.getInstance(this).newTracker(R.xml.tracker_global);
}

return global;
Expand Down
3 changes: 0 additions & 3 deletions analytics.xml.example → tracker.xml.example
Expand Up @@ -4,7 +4,4 @@ tools:ignore="TypographyDashes">
<string name="ga_trackingId">UA-XXX-YY</string>
<bool name="ga_autoActivityTracking">true</bool>
<bool name="ga_reportUncaughtExceptions">true</bool>
<bool name="ga_anonymizeIp">true</bool>
<string name="ga_logLevel">warning</string>
<integer name="ga_dispatchPeriod">1</integer>
</resources>

0 comments on commit c5b9b05

Please sign in to comment.