omit tag escape pattern from resulting RawString element output #170
Conversation
src/template.rs
Outdated
| @@ -377,12 +377,18 @@ impl Template { | |||
| { | |||
| let (line_no, col_no) = parser.input().line_col(prev_end); | |||
| if token.rule == Rule::raw_block_end { | |||
| let text = &source[prev_end..token.start]; | |||
| let mut text = &source[prev_end..token.start]; | |||
| if text.starts_with("\\{{") { | |||
There was a problem hiding this comment.
hi @softprops , what if the \\{{ is not at beginning of a raw_text, like hello \\{{world}}
There was a problem hiding this comment.
And we can make this a function to avoid duplicated code
There was a problem hiding this comment.
Good call. I wasn't sure of the grammar only parsed raw text with these at the beginning. I updated the tests, impl, and refactored to a method
src/template.rs
Outdated
| @@ -135,6 +135,13 @@ impl Template { | |||
| } | |||
| } | |||
|
|
|||
| fn unescape_tags<T>(txt: T) -> String | |||
| where | |||
| T: Into<String>, | |||
There was a problem hiding this comment.
Can we just use &str here to avoid creating a String just for replace?
There was a problem hiding this comment.
Good call. I didn't see str had that impl. I'll update and push that change tonight
|
Thank you @softprops for your patient! I will create a release later today. |
|
bawler. Ill grab that and pull it into porteurbars so I think I should be set for our company hackathon. Thanks so much for the fast feedback! |
I think I covered all the cases here. It did seem a bit repetitive but no more repetitive then the existing code for emitting
RawStrings.Ideally I would have liked to find a way to do this in the grammar itself but I couldn't find a clear path for that. I'm new to the pest syntax but familiar with scala's parser combinator library and couldn't find the equivalent of scala's
^^operator to transform the grammar