-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problems between checks within the same input
#95
Comments
Perhaps this is an ordering issue. It looks like it would make sense to always have Would changing the order of the checks solve this for you? |
In theory, it is correct to take the first check and fall immediately on it. If the first check passes, then take the second and fall on it. And so on until the end. |
That is, there is not a problem in ordering, but a problem in the positioning of these checks. That is, first need to take the first rule and it doesn’t matter what it is - type or inclusion. |
In theory need to add all the checks to an array and run them in a loop. But I'm not sure. 😬 Need to discuss the approach. |
Oh, I see, you mean that That would make total sense! However it would require rewriting how conditions are applied internally. I’d be happy to accept a pull-request going in this direction. Or else, a smaller change that would fix this specific problem here would be to place |
Here we are talking about all the checks, and not just about these two. Those two are just examples. In an amicable way it is necessary to introduce new logic. I'll try to provide a draft as soon as possible. |
Released in v3.6.0 🚀 |
There is this code in the application:
When using it:
Gives an error:
That is, the check for the type of the input value is ignored.
The text was updated successfully, but these errors were encountered: