Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credits #1

Closed
floatinghotpot opened this issue Mar 25, 2016 · 1 comment
Closed

Credits #1

floatinghotpot opened this issue Mar 25, 2016 · 1 comment

Comments

@floatinghotpot
Copy link

As this project is totally copied from my project, without any actual improvement:
cordova-plugin-admob

Hope you can mention it in Credits.

@sunnycupertino
Copy link
Owner

Hi Raymond. We did use it as a template, but your project actually didn't work on either iOS or Android, we have done a lot of work on it since then, so it in't true that it is completely copied and without improvement. It also used (at the time we checked) an old version of the iOS libraries, so we completely replaced them. After replacing them we had to change a lot of code, not to mention rewrite the cordova iOS plugin initialization, etc. Also we stabilized and simplified it's operation in Android. We will put something in the credits though, thank you for what you provided.

@sunnycupertino sunnycupertino changed the title Copyright & Credits Credits Mar 25, 2016
Repository owner locked and limited conversation to collaborators Mar 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants