Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Video Resize #18

Closed
Denoder opened this issue Dec 22, 2016 · 3 comments
Closed

[Suggestion] Video Resize #18

Denoder opened this issue Dec 22, 2016 · 3 comments

Comments

@Denoder
Copy link

Denoder commented Dec 22, 2016

Consider putting

      window.addEventListener('resize', updateDisplayArea);

outside of player.fluid() that way it would update if someone is using window.resze();
to define their player width/height (normally this is done on the embedded server)

@SunnyLi
Copy link
Owner

SunnyLi commented Dec 30, 2016

Is there a scenario where you couldn't enable player.fluid() mode?
or does that not work properly on embedded server?

Would having another differently named event like resize-player_id
that triggers updateDisplayArea work for you? so that it only executes
on the player instance in question when there are multiple on the page.

@Denoder
Copy link
Author

Denoder commented Dec 31, 2016

well, when i enabled fluid, the videos would get distorted, because the padding of the responsive fluid settings would shift the videos downward

@SunnyLi SunnyLi closed this as completed in b8064f6 Jan 9, 2017
@SunnyLi
Copy link
Owner

SunnyLi commented Jan 9, 2017

Sorry for the delay, after some thought I've made the exact change you've suggested
since it keeps everything simple and more likely to resolve your problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants