Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[videojs 5.x] videojs.Button is undefined #4

Closed
smad2005 opened this issue Oct 20, 2015 · 7 comments
Closed

[videojs 5.x] videojs.Button is undefined #4

smad2005 opened this issue Oct 20, 2015 · 7 comments

Comments

@smad2005
Copy link

TypeError: videojs.Button is undefined

108L: AssButton = videojs.Button.extend();

i'm using instruction from https://github.com/videojs/video.js#quick-start

 <link href="http://vjs.zencdn.net/5.0/video-js.min.css" rel="stylesheet">
 <script src="http://vjs.zencdn.net/5.0/video.min.js"></script>
@SunnyLi
Copy link
Owner

SunnyLi commented Oct 21, 2015

videojs 5.0 made many internal API changes which is what caused this breakage since videojs.Button was part of the internal API that really shouldn't have been used..

For now the latest videojs 4.x version should still work and I will eventually update this plugin to support videojs 5.x in the near future.

@SunnyLi
Copy link
Owner

SunnyLi commented Oct 21, 2015

If losing the ability to toggle subtitle visibility is not a major concern (so that subtitle will always be visible), then you can disable the toggle button creation step so that this plugin will continue to work on videojs 5.0.

@smad2005
Copy link
Author

Thank you

@anonym24
Copy link

anonym24 commented Nov 3, 2015

video.js 5 also has the Responsive Sizing feature ( data-setup='{"fluid":true} ), but if it's enabled subtitles aren't shown correctly.
Is it possible to fix it? (it is has to understand the new values for width and height)

@SunnyLi
Copy link
Owner

SunnyLi commented Nov 11, 2015

Sorry for the late response. I'm working on updating the plugin to support videojs 5.x now (so that the button doesn't break the plugin initialization) and will see if I can also get responsive sizing to work. It'll probably be put in a v5.x branch since it will definitely break videojs 4.x support.

@SunnyLi
Copy link
Owner

SunnyLi commented Nov 13, 2015

I've released v0.5 which adds support for videojs 5.x and some partial support for fluid mode.

@smad2005 smad2005 changed the title videojs.Button is undefined [videojs 5.x] videojs.Button is undefined Nov 13, 2015
@smad2005
Copy link
Author

Thanks, my issue has resolved. 7308ab5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants