-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some questions about videoj-ass #5
Comments
Hey,
The plugin executes on the client side so the client will have to be able to read the
Yes, videojs 5 compatible code is on the
It should work on all the latest desktop and mobile browsers. What I said there refers to
You can use CSS |
Thank you. Anyway I use a self-hosted video-js, used here: https://github.com/videojs/video.js/releases/tag/v5.4.4 I also would like to use a self-hosted videojs-ass. How can I do? |
Thank you. I done this. Anyway doesn't work. |
for doesn't work I mean the subtitles oesn't appears on player and doesn't appear the button |
Can you paste the fully rendered html template? I can't help you with just the php partial you've given me, I don't know what version of videojs and videojs-ass you are using or why things are failing.. preferably if you paste it on jsbin or codepen and see that it renders the player so that I can see what went wrong.. |
Here's to you: http://jsbin.com/zalavepari/edit?html,css,output |
Hi, have you got my last message? |
"giggioman00, you should not using remote path for subtitles. and yeah even subtitles in standart track won't work on jsbin.com with remote subtitles..." Well, trying in localhost with local subtitles doesn't work either. |
you have to run it on that server where subtitles are keeping (so it won't work if subtitles on test995.altervista.org but you run html on jsbin) |
http://jsbin.com/fuziyecahi/edit?html,css,output |
It works... |
"Do you mean this is not possible?" no, i mean about different server for subtitles |
Thank you. Now I'm making some test. I removed vjs-fluid but subtitles seems to be too big. The source file is the same in both and the ass have the right resolution of the video. |
where can I download "[150327][Collaboration Works]Mankitsu Happening 01 RAW.mp4" ? found it I will check it |
Hi, for the moment I'm not testing on test995.altervista.org but I'm testing on localhost with other file video. |
yeah... there is a difference in video-js and windows players (for e.g.) |
Ok thank you :) I'm waiting an answer from him then |
Hey @giggioman00 sorry I wasn't able to respond sooner. For your As @anonym24 had shown, moving the plugins initialization code above the hotkeys block solves the problem. The reason for why the subs aren't showing was because your server didn't have CORS setup to allow external web site to hotlink your subs which I guess works in you favor.. Anyways, I will now go add P.S. kudos to @anonym24 for helping out. 👍 |
Use DOM element property `offsetWidth` and `offsetHeight` to get player element's actual dimension so that it will work properly with fluid mode (and non-fluid mode). Refs #5
Thank you very much. Is everything fixed right now? |
Yes, just checkout out the latest version on branch |
Yes, now works fine! Thank you very much, that was so fast |
In that thread they said there is something to fix by your side... |
I think instead of using the libjass fontMap preload method, including the CSS If you tried the above method and it still didn't solve the font size issue than I don't know what else to suggest as this plugin is essentially just a wrapper and doesn't make any decision on what font or font size to render.. One thing you could do if the subtitle file is dynamically generated is to just increase/decrease font size there? Edit: Actually, looking at your comment on the other issue thread you should try to get it working using the DefaultRenderer on a basic |
This is not correct. WebRenderer uses the fontMap to be able to calculate font metrics as part of initialization. Without this it is very likely that it will calculate metrics for a system font before the web font is downloaded, and then this wrong font metric will persist forever. |
@Arnavion But once the browser has downloaded the font already, on subsequent refresh the font will likely be cached and
I don't see how this is possible assuming the metric is stored within My point is that I agree that it will likely not work on first load but once the font is downloaded and cached then on the subsequent load/refresh the font metric will be calculated correctly. and of course I should implement the fontMap so it will also work on the first run.. but I think switching the font might not solve OPs issue. |
|
This is needed to ensure the fonts are loaded before the library is fully initialized so that font metric can be correctly calculated. Refs #5
Alright, I've added the You can set it like so:
or use |
Hi. Sorry if I bother you again. People who usually doesn't know much about internet could not know what that button is. If they click the button without know what it does and then they don't see subtitles anymore, probably they will spam on the comments that they are not able to see the subtitles. thank you |
You can always add the tool-tip in yourself. Here's one I made which you can just drop into your videojs
However, instead of using what I have given you, you can probably just use some jQuery plugin that does all that with better result.. Also, you can change the button icon through CSS if you don't find the current one intuitive. |
Closing due to inactivity and that the initial issue in OP has already been addressed. |
Hi guys, I have some questions about this plugin.
I seen the .ass file appear on HTML source. There is a way for hide this or unable people to download .ass?
Is this plugin compatible with videojs 5?
In this page: https://www.npmjs.com/package/videojs-ass you say "If you are not on a phone or using a very bad browser, come check out the demo here". So, will the subtitle appear only on desktop browser?
What about fonts? As far as I know, You you put an .ass file inside a .mkv you need to attach also the font used in your .ass, otherwise the custom font you choose won't appear. Shouldn't be something similar with this plugin?
The text was updated successfully, but these errors were encountered: