Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ford/Tesla missing car controller "c" when they call create_common_events() #185

Closed
twilsonco opened this issue Jun 17, 2023 · 2 comments
Closed

Ford/Tesla missing car controller "c" when they call create_common_events() #185

twilsonco opened this issue Jun 17, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@twilsonco
Copy link
Contributor

twilsonco commented Jun 17, 2023 •
edited

Describe the bug

A car control objected is expected in the create_common_events() function but missing from the call for Ford and Tesla. That argument is not in the create_common_events definition in Comma master.
Screenshot 2023-06-17 at 9 03 07 AM

Here's the thrown exception on a ford maverick
exception

Provide a route where the issue occurs

foo

openpilot version

SP 0.9.2.2

Additional info

No response
@twilsonco twilsonco added the bug Something isn't working label Jun 17, 2023
@sunnyhaibin
Copy link
Collaborator

Thanks for the report. Ford is being tracked and worked on at the moment; Tesla is currently not supported and should be behind dashcam mode upstream. I will send out an update on the sunnypilot Discord server when it is ready for Ford users to test.

@sunnyhaibin
Copy link
Collaborator

This issue has been resolved in the latest dev-c3, and will make its way to staging-c3 and release-c3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@twilsonco @sunnyhaibin