Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toyota/Lexus - Enhanced Speed Control - ACC speed setting #187

Closed
markhatchell opened this issue Jun 28, 2023 · 4 comments
Closed

Toyota/Lexus - Enhanced Speed Control - ACC speed setting #187

markhatchell opened this issue Jun 28, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@markhatchell
Copy link

Hello, Thanks for a great version of openpilot with wonderful features!

I was curious if there were plans to expand the Enhanced Speed Control to Toyota/Lexus models.

I can help test if needed.

Car Make: Lexus
Car Model: NX300
Car Year: 2018
Hardware: Comma Three

Thanks,
Mark

@markhatchell markhatchell added the enhancement New feature or request label Jun 28, 2023
@sunnyhaibin
Copy link
Collaborator

Enhanced Speed Control works on all Toyota/Lexus platforms that use openpilot longitudinal control. It seems that your car by default uses stock Toyota longitudinal control. According to CARS.md, You will need to install the smartDSU to enable openpilot longitudinal control on your car.

image
image

@markhatchell
Copy link
Author

Thanks for the reply. I had found the smartDSU hardware as being a requirement for actual longitudinal control however, I was under the impression that the enhanced speed control feature sent messages to the cars stock ACC to adjust the speed setting letting the stock system still do longitudinal control. That is what I was asking about getting working.

@sunnyhaibin
Copy link
Collaborator

Thanks for the reply. I had found the smartDSU hardware as being a requirement for actual longitudinal control however, I was under the impression that the enhanced speed control feature sent messages to the cars stock ACC to adjust the speed setting letting the stock system still do longitudinal control. That is what I was asking about getting working.

Enhanced Speed Control requires openpilot longitudinal control or Custom Stock Longitudinal Control. Toyota/Lexus currently is not compatible with Custom Stock Longitudinal Control. For this platform, the best option is to install smartDSU and to allow openpilot longitudinal control to use Enhanced Speed Control.

@markhatchell
Copy link
Author

Ok thanks lots!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants