Optional autofocus the filter table textbox through an option #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only if autofocus setting is true (added the setting with default as true also)
|
For accessibility, it's generally a bad idea to add autofocus to fields. This is because visitors using accessible browsers (such as screen readers) are automatically jumped into a field when the page is loaded and have no context for where they are and what's going on. That said, I think the idea is a sound one, but the page author should have to enable autofocus specifically, knowing that it's not preferred for accessibility reasons. |
sunnywalker
added a commit
that referenced
this pull request
Mar 19, 2014
Optional autofocus the filter table textbox through an option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a autofocus option (enabled by default) and tested it (in Chrome) in both enabled and disabled. Works pretty well. Also updated the readme to reflect the option.