-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
sunodo shell should provide an option to define the shell to use #469
Comments
Can you describe why it is needed ? as far as I know this sub-command starts a shell in cartesi machine of application that is a docker container that has bash. |
I'm working on a small image with busybox, and face the problem of not having I could fix it easily by creating a symlink, but It felt weird having to do this. We could have a default and allow to change for whatever shell ( Also, my suggestion looks weird reading this afterward, this |
could use I'll send a PR. |
Why don't we provide an option to exec something in the cartesi machine, instead of having a specific command for shell?
An interactive flag may also be necessary. |
U mean Something like this ? sunodo exec --command "ls -la" |
I mean |
My worry with |
Yeah, but |
I'm going to send a PR for it. |
Is this customization really necessary? |
I created it as a feature request. It's necessary for my use case.
We could have this as a requirement somewhere. After we start using the
I agree. We need a better development workflow written down somewhere so that collaborators don't start working on things that were not discussed and got a tag or milestone that defines a issue as good-to-go. |
So I guess we can wait until
A simple label can take care of that. |
|
馃摎 Context
The shell that's called by
sunodo shell
is hardcoded to/bin/bash
.It should be possible to define another shell.
鉁旓笍 Solution
Default to
/bin/bash
and add a--shell
argument to define a different one.sundo shell --shell=/bin/sh
The text was updated successfully, but these errors were encountered: