Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declass ASDA #42

Closed
nabobalis opened this issue Dec 8, 2019 · 12 comments
Closed

Declass ASDA #42

nabobalis opened this issue Dec 8, 2019 · 12 comments

Comments

@nabobalis
Copy link
Contributor

nabobalis commented Dec 8, 2019

When pull request #40 is merged in, it would be worthwhile to declass the code into a series of functions.

@nabobalis nabobalis reopened this Apr 20, 2021
@sunpy sunpy deleted a comment from jeffreypaul15 Apr 20, 2021
@sunpy sunpy deleted a comment from jeffreypaul15 Apr 20, 2021
@sunpy sunpy deleted a comment from jeffreypaul15 Apr 20, 2021
@sunpy sunpy deleted a comment from jeffreypaul15 Apr 20, 2021
@sunpy sunpy deleted a comment from jeffreypaul15 Apr 20, 2021
@nabobalis nabobalis closed this as not planned Won't fix, can't repro, duplicate, stale Jan 16, 2023
@nabobalis nabobalis reopened this Feb 13, 2023
@Telomelonia
Copy link

@nabobalis
Are the classes to be removed after making the functions out of classes?

This was referenced Apr 1, 2023
@nabobalis
Copy link
Contributor Author

@nabobalis Are the classes to be removed after making the functions out of classes?

At the same time?

@Telomelonia
Copy link

@nabobalis Are the classes to be removed after making the functions out of classes?

At the same time?

No .. no actually I was thinking that declass meant to completely remove the class but now it is ok I have defined the function separately

@nabobalis
Copy link
Contributor Author

@nabobalis Are the classes to be removed after making the functions out of classes?

At the same time?

No .. no actually I was thinking that declass meant to completely remove the class but now it is ok I have defined the function separately

What is the reason to define it separately and keep the class?

@Telomelonia
Copy link

I'm just being cautious as I noticed the ASDA class was inherited in the Lamb_Oseen class here... so at first, I felt this inheritance reduces a lot of parameters in the functions. And so, I would like to discuss this before removing the classes.

@Ghaithq
Copy link
Contributor

Ghaithq commented Feb 7, 2024

can I work on this? @nabobalis

@nabobalis
Copy link
Contributor Author

Sure.

@010100100100011101010100

@nabobalis I will really glad to work and contribute from my side. It is wrong on my part to not understand the issue completely, could you kindly provide some assistance?

@nabobalis
Copy link
Contributor Author

@nabobalis I will really glad to work and contribute from my side. It is wrong on my part to not understand the issue completely, could you kindly provide some assistance?

Hello @010100100100011101010100, currently this issue is being worked on by @Ghaithq. If you want to help, you can ask them otherwise I would suggest another issue.

@bhavana-hn
Copy link

@nabobalis I will really glad to work and contribute from my side. It is wrong on my part to not understand the issue completely, could you kindly provide some assistance?

Hello @010100100100011101010100, currently this issue is being worked on by @Ghaithq. If you want to help, you can ask them otherwise I would suggest another issue.

@Ghaithq , Could you please explain the issue once clearly? I cannot find the issue specified anywhere?

@nabobalis
Copy link
Contributor Author

@nabobalis I will really glad to work and contribute from my side. It is wrong on my part to not understand the issue completely, could you kindly provide some assistance?

Hello @010100100100011101010100, currently this issue is being worked on by @Ghaithq. If you want to help, you can ask them otherwise I would suggest another issue.

@Ghaithq , Could you please explain the issue once clearly? I cannot find the issue specified anywhere?

Hello @rachelle-hc, do you mean the open pull request addressing this issue? If so that is here: #185

Or would you like a actual concrete issue description? I relassise that I opened this issue with 0 details but I never came back to improve on it.

@nabobalis
Copy link
Contributor Author

Closed by #185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants