Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NumFOCUS logo to website #87

Merged
merged 4 commits into from Apr 26, 2017
Merged

Added NumFOCUS logo to website #87

merged 4 commits into from Apr 26, 2017

Conversation

DuyguKeskek
Copy link
Contributor

@DuyguKeskek DuyguKeskek commented Apr 23, 2017

Congrats on your new sponsorship 馃憤 I want to resolve the issue #86

Currently, It looks like : (Inspired from astropy and fenicsproject and the footer bar is inspired from quantecon )

About section :

about

Blog section : (The footer appears on the about,blog,contribute, and help section)

blog

@ehsteve
Copy link
Member

ehsteve commented Apr 25, 2017

馃憤

@ehsteve
Copy link
Member

ehsteve commented Apr 25, 2017

I think it might be neat to also have it in the footer bar like this site.

@DuyguKeskek
Copy link
Contributor Author

@ehsteve It's a great idea :) I will add a footer and customize it asap. 馃憤

@ehsteve
Copy link
Member

ehsteve commented Apr 25, 2017

thanks @DuyguKeskek!

@DuyguKeskek
Copy link
Contributor Author

Hello @ehsteve! I added the footer bar, can you please have a look at it ?

@ehsteve
Copy link
Member

ehsteve commented Apr 26, 2017

@DuyguKeskek looks really good! One small consideration, might it be better to use svgs instead of pngs?

@DuyguKeskek
Copy link
Contributor Author

Thanks for your review @ehsteve :) I also prefer using svgs to have smaller file sizes and increased speed.
I will convert them 馃憤

@ehsteve
Copy link
Member

ehsteve commented Apr 26, 2017

@DuyguKeskek A quick look around and I can't find svg version of the numfocus logo. Any luck on your end? I can email numfocus and ask directly.

@souravc4
Copy link
Contributor

souravc4 commented Apr 26, 2017

Hi @DuyguKeskek, nice work overall, but might I suggest using a current colour code from the website (#444444) or (#f7f7f9) for the footer - (#e5e5e5) looks a bit out of sync for me.
So depending on the colour it should either look like this
oie_wmlqc7rw0or4
OR
new

@souravc4
Copy link
Contributor

Also since we can't find the SVG originals of the numfocus logo, I would suggest using this white text png(http://numfocus.wpengine.com/wp-content/uploads/2017/03/1457562110.png) which they themselves use for their website(numfocus.org).

@souravc4
Copy link
Contributor

souravc4 commented Apr 26, 2017

Note that png is stored on their private server it seems, also manual conversion of png to svg just for the sake of it wouldn't be recommended now. @ehsteve

@DuyguKeskek
Copy link
Contributor Author

@ehsteve Good news ! I found the svg logo :) Fenicsproject already makes use of it. I replaced the pngs with the svg and committed 馃憤

@DuyguKeskek
Copy link
Contributor Author

Hi @souravc4 ! Thanks for appreciating my work :) If we make the footer dark, the numfocus logo will not be so clear. It is suitable to use #f7f7f9 for the footer, but I made the footer consistent with the border color that is #e5e5e5 and I think it looks better. Also, I was already using that white text png of the numfocus website. Thanks for your recommendations !

@souravc4
Copy link
Contributor

souravc4 commented Apr 26, 2017

I meant for the numfocus-logo.png which u used in the about section. Since I can't find an official repo for numfocus logo and a svg original isn't available in their website's repo I assume Fenicsproject got the svg from manual conversion of the original png so I would consider sticking to their png for originality purposes.

@DuyguKeskek
Copy link
Contributor Author

@souravc4 Since Fenicsproject already uses this, I think there won't be any problem. - also it is way better than the png one in terms of resolution -

Copy link
Member

@ehsteve ehsteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@ehsteve
Copy link
Member

ehsteve commented Apr 26, 2017

ping @Cadair

@Cadair Cadair merged commit da712be into sunpy:master Apr 26, 2017
@DuyguKeskek DuyguKeskek deleted the test1 branch April 27, 2017 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants