New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added NumFOCUS logo to website #87
Conversation
馃憤 |
I think it might be neat to also have it in the footer bar like this site. |
@ehsteve It's a great idea :) I will add a footer and customize it asap. 馃憤 |
thanks @DuyguKeskek! |
Hello @ehsteve! I added the footer bar, can you please have a look at it ? |
@DuyguKeskek looks really good! One small consideration, might it be better to use svgs instead of pngs? |
Thanks for your review @ehsteve :) I also prefer using svgs to have smaller file sizes and increased speed. |
@DuyguKeskek A quick look around and I can't find svg version of the numfocus logo. Any luck on your end? I can email numfocus and ask directly. |
Hi @DuyguKeskek, nice work overall, but might I suggest using a current colour code from the website (#444444) or (#f7f7f9) for the footer - (#e5e5e5) looks a bit out of sync for me. |
Also since we can't find the SVG originals of the numfocus logo, I would suggest using this white text png(http://numfocus.wpengine.com/wp-content/uploads/2017/03/1457562110.png) which they themselves use for their website(numfocus.org). |
Note that png is stored on their private server it seems, also manual conversion of png to svg just for the sake of it wouldn't be recommended now. @ehsteve |
@ehsteve Good news ! I found the svg logo :) Fenicsproject already makes use of it. I replaced the pngs with the svg and committed 馃憤 |
Hi @souravc4 ! Thanks for appreciating my work :) If we make the footer dark, the numfocus logo will not be so clear. It is suitable to use #f7f7f9 for the footer, but I made the footer consistent with the border color that is #e5e5e5 and I think it looks better. Also, I was already using that white text png of the numfocus website. Thanks for your recommendations ! |
I meant for the |
@souravc4 Since Fenicsproject already uses this, I think there won't be any problem. - also it is way better than the png one in terms of resolution - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
ping @Cadair |
Congrats on your new sponsorship 馃憤 I want to resolve the issue #86
Currently, It looks like : (Inspired from astropy and fenicsproject and the footer bar is inspired from quantecon )
About section :
Blog section : (The footer appears on the about,blog,contribute, and help section)