Configure giles to check PRs #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samaloney
force-pushed
the
feat-enable-giles
branch
from
6f6fdde
to
d2de90d
Compare
DanRyanIrish
changed the title
DanRyanIrish
approved these changes
Jun 15, 2022
hayesla
approved these changes
Jun 15, 2022
pyproject.toml
Outdated
Comment on lines
30
to
34
| help_url = "https://github.com/sunpy/sunxspex/blob/main/changelog/README.rst" | ||
|
|
||
| changelog_missing_long = "There isn't a changelog file in this pull request. Please add a changelog file to the `changelog/` directory following the instructions in the changelog [README](https://github.com/sunpy/sunpy/blob/main/changelog/README.rst)." | ||
|
|
||
| type_incorrect_long = "The changelog file you added is not one of the allowed types. Please use one of the types described in the changelog [README](https://github.com/sunpy/sunpy/blob/main/changelog/README.rst)" |
There was a problem hiding this comment.
The sunxspex default branch is still master (that can probably be changed?) so the help_url is currently 404. The updated towncrier types here seem to correspond to the sunpy/sunpy version which is out of sync with the sunpy/sunxspex changelog readme (changelog/README.rst). Maybe this readme should also be re-synced with the sunpy version, and the URLs in changelog_missing_long and type_incorrect_long above updated to point to the README within the sunxspex repo.
samaloney
force-pushed
the
feat-enable-giles
branch
from
f8a22d4
to
e53411c
Compare
samaloney
force-pushed
the
feat-enable-giles
branch
from
e53411c
to
bf0f8e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Configure bot to check PR have proper change logs