Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

popRates should be renamed to popInfo #630

Open
salvadord opened this issue Oct 21, 2021 · 1 comment
Open

popRates should be renamed to popInfo #630

salvadord opened this issue Oct 21, 2021 · 1 comment
Assignees

Comments

@salvadord
Copy link
Collaborator

@joewgraham Since in the new plotRaster function, the 'popRates' argument shows not only rates, but also num cells and num syns, it should probably be renamed to 'popInfo'

Alternatively, can add popNumCells and popNumSyns as boolean arguments. This would actually keep backward compatibility. Right now, I have to add 'popRates="minimal"' to all the large scale models so that the legend fits.

https://github.com/Neurosim-lab/netpyne/blob/e6e6481125963fc6d1a209bc96980d3a9944fd43/netpyne/plotting/plotRaster.py#L156

@joewgraham
Copy link
Contributor

I like the idea of switching to popInfo better... I like having fewer parameters and I don't like the idea of giving so many possible permutations of info to include.

We could change the default to "minimal", but for the smaller networks I've been dealing with, I like to see the additional pop info right on the plot... What do you think, @salvadord ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants