Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installation error on python 3.3 #1

Closed
EnricoGiampieri opened this issue Apr 24, 2013 · 8 comments
Closed

installation error on python 3.3 #1

EnricoGiampieri opened this issue Apr 24, 2013 · 8 comments

Comments

@EnricoGiampieri
Copy link

Hi! I really like the job you are doing on funcy (even if it lacks a little on the inline documentation side :) ).
It works fine on python 2.7, but on python 3.3 it gives me the following error:

Installing collected packages: funcy
Running setup.py install for funcy
File "/usr/local/lib/python3.3/dist-packages/funcy/colls.py", line 88
return walk(lambda (k, v): (f(k), v), coll)
^
SyntaxError: invalid syntax

This is because in python 3 the lambda function cannot unpack tuple.
I installed it with:
pip install -U funcy

@Suor
Copy link
Owner

Suor commented Apr 24, 2013

Yeah, and thats no surprise. It was not intended to run on python 3. And am I'm not going to support or maintain a python 3 port for now, sorry.

If a champion arises willing to handle all of this, I will surely support him. But there are more problems with python 3 than just lack of syntax features. There were some semantic changes as well (map and filter now return iterators) which need funcy to be adjusted - for now funcy is all in that func/ifunc semantics of python 2. I don't have a solid opinion what to do about that in python 3 funcy version and that adds up to my decision to avoid python 3 version for now.

If you are willing to be that champion or just have an idea how funcy should handle that ill python 3 semantics, I will be glad to hear it.

@EnricoGiampieri
Copy link
Author

For now I have made a crude support for python 3 (it just needed some control on import exception, later i will try and do some more robust import method). How am i supposed to run the tests?

@Suor
Copy link
Owner

Suor commented Apr 24, 2013

I don't really understand what you mean you did. For testing - what's wrong with py.test? You can also set up tox if you wish to test in several pythons at once.

@EnricoGiampieri
Copy link
Author

sorry, written in a hurry and wasn't clear. I was wandering if there was an automated test suite, as I'm not familiar with py.test (I'm more used to unittest and nose). I just worked out how to do it, so I'm doing the tests right now...

@Suor
Copy link
Owner

Suor commented Dec 29, 2013

Added python 3 support in 2b2ae11 and eb62cb2. Docs to be updated.

@kvesteri
Copy link

kvesteri commented Jan 2, 2014

Really looking forward to this! Most of the OS components I've published will definitely use funcy once it supports python 3.3.

@Suor
Copy link
Owner

Suor commented Jan 5, 2014

Python 3 supported in 0.9.

@Suor Suor closed this as completed Jan 5, 2014
@Suor
Copy link
Owner

Suor commented Jan 5, 2014

Also mind interface differences (some differently named functions) in python 3 http://funcy.readthedocs.org/en/latest/python3.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants