Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuration option for "snippet length" #93

Closed
schmeisers opened this issue Jun 30, 2013 · 3 comments
Closed

configuration option for "snippet length" #93

schmeisers opened this issue Jun 30, 2013 · 3 comments

Comments

@schmeisers
Copy link

This is a feature request for a configuration option for "snippet length." It would be nice to have more than 80 chars for using sup fullscreen on a wide monitor.

@5long
Copy link
Contributor

5long commented Jul 14, 2013

TL;DR - Will do after #92 is merged.

After using mime-decode hook to view HTML-only emails, I'm feeling the same need for this to be configurable.

A super-clean-and-correct approach would be extract the snippet-composing logics from message-loading time and move it to rendering time.

But for now I can settle with a config-based solution since the message-loading time already reads from config.

Besides, the truncating logic doesn't look good on non-ascii string. I'll wait for merging #92 first, which introduces wide-char-aware slicing.

@gauteh
Copy link
Member

gauteh commented Jul 25, 2013

I think snippets are stored in the index, while re-calculating a snippet would require the message source to be read again. Worth taking into consideration. Upping the snippet length to say 250 chars and then using a screen-size dependent length at render time could be an option.

@gauteh
Copy link
Member

gauteh commented Oct 7, 2014

Closing, no activity.

@gauteh gauteh closed this as completed Oct 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants