Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing a few auth providers that are already supported in supabase. #292

Closed
hikchoi opened this issue Aug 16, 2023 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@hikchoi
Copy link

hikchoi commented Aug 16, 2023

Bug report

Describe the bug

providers figma, kakao, and zoom are missing from the types defined in this project.
I'm referencing the js counterpart of this repo and what the supabase dashboard tells me here. Not sure if there's another source of truth for the supported third party providers.

See here

For now my workaround is to simply build the endpoint manually like so:

https://{BASE_URL}/auth/v1/authorize?provider=kakao

and it works just fine. (at least for the kakao provider)

To Reproduce

I'm using part of our project's code that uses the supabase python client here as an example, but from a quick skim of both repos, I think it's simply an omission in the upstream (gotrue-py).

...
from .settings import get_settings
from supabase import create_client, Client
supabase: Client = create_client(
    settings.SUPABASE_URL, 
    settings.SUPABASE_SERVICE_ROLE_KEY
)
response = supabase.auth.sign_in_with_oauth({
        "provider": "kakao",
})
...

will result in:

pydantic.error_wrappers.ValidationError: 1 validation error for OAuthResponse
provider
unexpected value; permitted: 'apple', 'azure', 'bitbucket', 'discord', 'facebook', 'github', 'gitlab', 'google', 'keycloak', 'linkedin', 'notion', 'slack', 'spotify', 'twitch', 'twitter', 'workos' (type=value_error.const; given=kakao; permitted=('apple', 'azure', 'bitbucket', 'discord', 'facebook', 'github', 'gitlab', 'google', 'keycloak', 'linkedin', 'notion', 'slack', 'spotify', 'twitch', 'twitter', 'workos'))

Expected behavior

All supported providers work normally

Screenshots

N/A

System information

Irrelevant

Additional context

Thanks for the great work, folks.

My main interest is to have the kakao provider work, if that provides any context at all.

I'm currently blocked with an update to the latest version because the pydantic version is too restrictive, so it would be really nice if #291 gets resolved with this as well so I can actually bump the version up to see this change active. 😄

@hikchoi hikchoi added the bug Something isn't working label Aug 16, 2023
@J0
Copy link
Collaborator

J0 commented Aug 23, 2023

Hey

The pydantic version should be fixed and you should be able to use the provider. Let me know if there are still issues though.

Thanks!

@J0 J0 closed this as completed Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants