Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify minor version of pydantic to avoid dependency issue #289

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

yuvanist
Copy link
Contributor

@yuvanist yuvanist commented Aug 3, 2023

What kind of change does this PR introduce?

Bug fix related to #286

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (69f5994) 37.65% compared to head (9258777) 37.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #289   +/-   ##
=======================================
  Coverage   37.65%   37.65%           
=======================================
  Files          25       25           
  Lines        2284     2284           
=======================================
  Hits          860      860           
  Misses       1424     1424           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@J0 J0 merged commit c2ed950 into supabase-community:main Aug 3, 2023
8 checks passed
@J0
Copy link
Collaborator

J0 commented Aug 3, 2023

Thanks!

@yuvanist
Copy link
Contributor Author

@J0 This PR got merged to the main branch but was not released. Can you do a minor release with the latest main branch?

@olirice
Copy link
Contributor

olirice commented Aug 16, 2023

@yuvanist pinning pydantic to 2.1 has caused problems for us upstream since it makes gotrue-py, postgrest-py and supabase-py incompatible with other popular libraries that use pydantic and have not yet upgraded to 2.0. e.g. Langchain, and FastAPI

see:
supabase-community/supabase-py#517

@olirice
Copy link
Contributor

olirice commented Aug 16, 2023

@J0 I didn't realize this wasn't in a release yet. That's lucky. Please don't cut any more releases until we can revert or add a compatibility layer

@yuvanist
Copy link
Contributor Author

@olirice that's sad that other libs still in 1.0. Got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants