Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused v1 files #323

Merged
merged 1 commit into from
Sep 16, 2023
Merged

refactor: remove unused v1 files #323

merged 1 commit into from
Sep 16, 2023

Conversation

J0
Copy link
Collaborator

@J0 J0 commented Sep 16, 2023

What kind of change does this PR introduce?

Removes all unused v1 files. Currently, it looks like we don't use the given imports This is a first step in bringing us up to speed ito v2

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +8.07% 🎉

Comparison is base (b0144ef) 37.46% compared to head (e9005e4) 45.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
+ Coverage   37.46%   45.53%   +8.07%     
==========================================
  Files          25       23       -2     
  Lines        2301     1893     -408     
==========================================
  Hits          862      862              
+ Misses       1439     1031     -408     
Files Changed Coverage Δ
gotrue/_sync/gotrue_client.py 30.27% <0.00%> (ø)
gotrue/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@J0 J0 merged commit 817fafb into main Sep 16, 2023
13 checks passed
@J0 J0 deleted the j0/remove_unused_v1 branch September 16, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant