feat: add OAuth PKCE (Sourcery refactored) #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| # Generate a random PKCE verifier using the secrets module | ||
| verifier = "".join(secrets.choice(charset) for _ in range(length)) | ||
|
|
||
| return verifier | ||
| return "".join(secrets.choice(charset) for _ in range(length)) |
There was a problem hiding this comment.
Function generate_pkce_verifier refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
This removes the following comments ( why? ):
# Generate a random PKCE verifier using the secrets module
Comment on lines
-152
to
+149
| # Encode the hash as URL-safe base64 | ||
| base64_encoded = base64.urlsafe_b64encode(sha256_hash).rstrip(b"=").decode("utf-8") | ||
|
|
||
| return base64_encoded | ||
| return base64.urlsafe_b64encode(sha256_hash).rstrip(b"=").decode("utf-8") |
There was a problem hiding this comment.
Function generate_pkce_challenge refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
This removes the following comments ( why? ):
# Encode the hash as URL-safe base64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #331 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
j0/pkcebranch, then run:Help us improve this pull request!