Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix: use pydantic v2 model.model_rebuild #373

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

AJamesPhillips
Copy link
Contributor

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

When I run tests I see the following warnings:

(venv) ... % pytest src/tests/integration/test_abc.py       
=========================================================================================== test session starts ============================================================================================
platform darwin -- Python 3.9.13, pytest-7.4.3, pluggy-1.3.0
rootdir: /Users/...
configfile: pytest.ini
plugins: anyio-4.1.0
collected 7 items                                                                                                                                                                                          

src/tests/integration/test_abc.py .......                                                                                                                                                    [100%]

============================================================================================= warnings summary =============================================================================================
venv/lib/python3.9/site-packages/gotrue/types.py:679: 19 warnings
  /Users/.../venv/lib/python3.9/site-packages/gotrue/types.py:679: PydanticDeprecatedSince20: The `update_forward_refs` method is deprecated; use `model_rebuild` instead. Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.3/migration/
    model.update_forward_refs()

venv/lib/python3.9/site-packages/pydantic/main.py:1206: 19 warnings
  /Users/.../venv/lib/python3.9/site-packages/pydantic/main.py:1206: PydanticDeprecatedSince20: The `update_forward_refs` method is deprecated; use `model_rebuild` instead. Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.3/migration/
    warnings.warn(

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
====================================================================================== 7 passed, 38 warnings in 1.77s ======================================================================================

What is the new behavior?

No warning messages are seen

Additional context

None

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fbddd6d) 45.37% compared to head (9d723df) 45.26%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
- Coverage   45.37%   45.26%   -0.11%     
==========================================
  Files          23       23              
  Lines        1955     1955              
==========================================
- Hits          887      885       -2     
- Misses       1068     1070       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@silentworks silentworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for this PR.

@silentworks silentworks merged commit fd94314 into supabase-community:main Nov 30, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants