fix: remove unnecessary async to on_auth_state_change #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow this got reverted on a refactor (supabase-community@e7ebc64) This causes problems when using the supabase client, since it's not being awaited: https://github.com/supabase-community/supabase-py/blob/main/supabase/_async/client.py#L90
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #374 +/- ##
=======================================
Coverage 45.37% 45.37%
=======================================
Files 23 23
Lines 1955 1955
=======================================
Hits 887 887
Misses 1068 1068 ☔ View full report in Codecov by Sentry. |
silentworks
approved these changes
Nov 29, 2023
|
Thank you for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
It fixes on_auth_state_change not be async. Somehow it got reverted on a refactor (e7ebc64)
What is the current behavior?
It was async.
What is the new behavior?
It's not async anymore.
Additional context
This causes problems when using the supabase client, since it's not being awaited: https://github.com/supabase-community/supabase-py/blob/main/supabase/_async/client.py#L90