Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass through timeout #369

Merged
merged 1 commit into from
Feb 11, 2023
Merged

fix: pass through timeout #369

merged 1 commit into from
Feb 11, 2023

Conversation

J0
Copy link
Collaborator

@J0 J0 commented Feb 11, 2023

timeout was not being passed through from constructor to postgrest

Fixes #293

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 11, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.18%.

Quality metrics Before After Change
Complexity 3.12 ⭐ 3.12 ⭐ 0.00
Method Length 42.75 ⭐ 43.17 ⭐ 0.42 👎
Working memory 9.73 🙂 9.73 🙂 0.00
Quality 67.98% 🙂 67.80% 🙂 -0.18% 👎
Other metrics Before After Change
Lines 185 186 1
Changed files Quality Before Quality After Quality Change
supabase/client.py 67.98% 🙂 67.80% 🙂 -0.18% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
supabase/client.py Client.__init__ 6 ⭐ 217 ⛔ 15 😞 43.39% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Base: 78.75% // Head: 78.75% // No change to project coverage 👍

Coverage data is based on head (8921e32) compared to base (6700ab5).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #369   +/-   ##
========================================
  Coverage    78.75%   78.75%           
========================================
  Files            9        9           
  Lines          160      160           
========================================
  Hits           126      126           
  Misses          34       34
Impacted Files Coverage Δ
supabase/client.py 91.80% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@J0 J0 merged commit abd1abb into develop Feb 11, 2023
@J0 J0 mentioned this pull request Feb 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

httpx.ReadTimeout: The read operation timed out
1 participant
@J0