Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON decoding issues #7

Open
NoahKamara opened this issue Nov 7, 2022 · 2 comments
Open

JSON decoding issues #7

NoahKamara opened this issue Nov 7, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@NoahKamara
Copy link

Bug report

I've noticed that JSON decoding has some issues (missing keys, optionals not handled) and that you're not using Codable to decode. Is there a particular reason for that?

As far as I'm aware, Codable is available on linux too according to this PR

The Bucket Model for example is almost entirely optional, which is not handled (maybe due to code generation from javascript?)

If there is no reason against implementation with Codable, I'd be up to doing that :)

@NoahKamara NoahKamara added the bug Something isn't working label Nov 7, 2022
@grdsdev
Copy link
Contributor

grdsdev commented Nov 8, 2022

Hi @NoahKamara this lib was first implemented without support for Codable (don't know why).
Migrate to Codable is in the roadmap, feel free to PR a change.

@maail
Copy link
Contributor

maail commented Jun 27, 2023

Noting that PR for this issue has been raised here #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants